environment.py: reduce # locks further#31643
Merged
becker33 merged 4 commits intospack:developfrom Jul 26, 2022
Merged
Conversation
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Member
Author
|
ping @becker33 |
4 tasks
becker33
approved these changes
Jul 26, 2022
3 tasks
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
* environment.py: reduce # of locks further
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactor of accumulated hacks, reducing the risk of timeouts due to locks further.
Note that previously
[s for s in all_specs if s.installed]was not wrapped in a read lock.