deprecate blacklist/whitelist in favor of include/exclude#31569
Merged
deprecate blacklist/whitelist in favor of include/exclude#31569
blacklist/whitelist in favor of include/exclude#31569Conversation
tldahlgren
reviewed
Jul 13, 2022
Contributor
tldahlgren
left a comment
There was a problem hiding this comment.
Some preliminary feedback/questions.
6e4a587 to
4659423
Compare
Member
Author
|
Added notes on the deprecation version to all the |
becker33
requested changes
Jul 13, 2022
daa3330 to
4f7c66a
Compare
becker33
previously approved these changes
Jul 13, 2022
alalazo
previously approved these changes
Jul 14, 2022
haampie
reviewed
Jul 14, 2022
For a long time the module configuration has had a few settings that use
`blacklist`/`whitelist` terminology. We've been asked by some of our users to replace
this with more inclusive language. In addition to being non-inclusive, `blacklist` and
`whitelist` are inconsistent with the rest of Spack, which uses `include` and `exclude`
for the same concepts.
- [x] Deprecate `blacklist`, `whitelist`, `blacklist_implicits` and `environment_blacklist`
in favor of `exclude`, `include`, `exclude_implicits` and `exclude_env_vars` in module
configuration, to be removed in Spack v0.20.
- [x] Print deprecation warnings if any of the deprecated names are in module config.
- [x] Update tests to test old and new names.
- [x] Update docs.
- [x] Update `spack config update` to fix this automatically, and include a note in the error
that you can use this command.
4f7c66a to
24629ab
Compare
alalazo
approved these changes
Jul 14, 2022
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
…ack#31569) For a long time the module configuration has had a few settings that use `blacklist`/`whitelist` terminology. We've been asked by some of our users to replace this with more inclusive language. In addition to being non-inclusive, `blacklist` and `whitelist` are inconsistent with the rest of Spack, which uses `include` and `exclude` for the same concepts. - [x] Deprecate `blacklist`, `whitelist`, `blacklist_implicits` and `environment_blacklist` in favor of `exclude`, `include`, `exclude_implicits` and `exclude_env_vars` in module configuration, to be removed in Spack v0.20. - [x] Print deprecation warnings if any of the deprecated names are in module config. - [x] Update tests to test old and new names. - [x] Update docs. - [x] Update `spack config update` to fix this automatically, and include a note in the error that you can use this command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a long time the module configuration has had a few settings that use
blacklist/whitelistterminology. We've been asked by some of our users to replace this with more inclusive language. In addition to being non-inclusive,blacklistandwhitelistare inconsistent with the rest of Spack, which usesincludeandexcludefor the same concepts.blacklist,whitelist,blacklist_implicitsandenvironment_blacklistin favor ofexclude,include,exclude_implicitsandexclude_env_varsin module configuration, to be removed in Spack v0.20.spack config updateto fix this automatically, and include a note in the error that you can use this command.@hnamLANL FYI -- sorry this took so long