Cray support: use linux platform for newer craype versions#29392
Merged
Cray support: use linux platform for newer craype versions#29392
Conversation
Member
|
FWIW, there are still many issues and unresolved tickets with Cray PE's without modules. This is 21.12: |
696d751 to
5c32958
Compare
|
It looks like you had an issue with style checks! I can help with that if you ask me! Just say:
... and I'll try to fix style and push a commit to your fork with the fix. Alternatively, you can run: $ spack style --fixAnd then update the pull request here. |
1 similar comment
|
It looks like you had an issue with style checks! I can help with that if you ask me! Just say:
... and I'll try to fix style and push a commit to your fork with the fix. Alternatively, you can run: $ spack style --fixAnd then update the pull request here. |
Member
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, black, flake8
==> Modified files
lib/spack/spack/compilers/cce.py
lib/spack/spack/platforms/cray.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 558 source files
mypy checks were clean
==> Running black checks
reformatted lib/spack/spack/compilers/cce.py
reformatted lib/spack/spack/platforms/cray.py
All done! ✨ 🍰 ✨
2 files reformatted.
black checks were clean
==> Running flake8 checks
lib/spack/spack/compilers/cce.py:6: [F401] 'os' imported but unused
flake8 found errors
I've updated the branch with isort fixes. |
|
It looks like you had an issue with style checks! I can help with that if you ask me! Just say:
... and I'll try to fix style and push a commit to your fork with the fix. Alternatively, you can run: $ spack style --fixAnd then update the pull request here. |
1 similar comment
|
It looks like you had an issue with style checks! I can help with that if you ask me! Just say:
... and I'll try to fix style and push a commit to your fork with the fix. Alternatively, you can run: $ spack style --fixAnd then update the pull request here. |
|
It looks like you had an issue with style checks! I can help with that if you ask me! Just say:
... and I'll try to fix style and push a commit to your fork with the fix. Alternatively, you can run: $ spack style --fixAnd then update the pull request here. |
1 similar comment
|
It looks like you had an issue with style checks! I can help with that if you ask me! Just say:
... and I'll try to fix style and push a commit to your fork with the fix. Alternatively, you can run: $ spack style --fixAnd then update the pull request here. |
Member
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, black, flake8
==> Modified files
lib/spack/spack/compilers/cce.py
lib/spack/spack/platforms/cray.py
lib/spack/spack/test/architecture.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 558 source files
mypy checks were clean
==> Running black checks
reformatted lib/spack/spack/test/architecture.py
All done! ✨ 🍰 ✨
1 file reformatted, 2 files left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
I've updated the branch with isort fixes. |
tgamblin
previously approved these changes
Nov 2, 2022
3bcb5f6 to
1194eaa
Compare
Member
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, black, flake8
==> Modified files
lib/spack/spack/compilers/cce.py
lib/spack/spack/platforms/cray.py
lib/spack/spack/test/architecture.py
var/spack/repos/builtin/packages/aluminum/package.py
var/spack/repos/builtin/packages/esmf/package.py
var/spack/repos/builtin/packages/mpich/package.py
var/spack/repos/builtin/packages/mvapich2/package.py
var/spack/repos/builtin/packages/opencoarrays/package.py
var/spack/repos/builtin/packages/scorep/package.py
var/spack/repos/builtin/packages/xsdk/package.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 566 source files
mypy checks were clean
==> Running black checks
reformatted lib/spack/spack/compilers/cce.py
reformatted lib/spack/spack/test/architecture.py
reformatted var/spack/repos/builtin/packages/scorep/package.py
All done! ✨ 🍰 ✨
3 files reformatted, 7 files left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Member
|
Pipeline failure is spurious and this PR doesn't affect that part of the pipeline. |
tgamblin
approved these changes
Nov 4, 2022
3 tasks
3 tasks
charmoniumQ
pushed a commit
to charmoniumQ/spack
that referenced
this pull request
Nov 19, 2022
Newer versions of the CrayPE for EX systems have standalone compiler executables for CCE and compiler wrappers for Cray MPICH. With those, we can treat the cray systems as part of the linux platform rather than having a separate cray platform. This PR: - [x] Changes cray platform detection to ignore EX systems with Craype version 21.10 or later - [x] Changes the cce compiler to be detectable via paths - [x] Changes the spack compiler wrapper to understand the executable names for the standalone cce compiler (`craycc`, `crayCC`, `crayftn`).
4 tasks
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
Newer versions of the CrayPE for EX systems have standalone compiler executables for CCE and compiler wrappers for Cray MPICH. With those, we can treat the cray systems as part of the linux platform rather than having a separate cray platform. This PR: - [x] Changes cray platform detection to ignore EX systems with Craype version 21.10 or later - [x] Changes the cce compiler to be detectable via paths - [x] Changes the spack compiler wrapper to understand the executable names for the standalone cce compiler (`craycc`, `crayCC`, `crayftn`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of the CrayPE for EX systems have standalone compiler executables for CCE and compiler wrappers for Cray MPICH. With those, we can treat the cray systems as part of the linux platform rather than having a separate cray platform.
This PR:
craycc,crayCC,crayftn).