Fix broken CI for package only PRs, make dateutil not strictly required#24484
Merged
sethrj merged 4 commits intospack:developfrom Jun 23, 2021
Merged
Fix broken CI for package only PRs, make dateutil not strictly required#24484sethrj merged 4 commits intospack:developfrom
sethrj merged 4 commits intospack:developfrom
Conversation
This commit forces the Python interpreter with an environment variable, to ensure that the Python set by the "setup-python" action is the one being used. Due to the policy adopted by Spack to prefer python3 over python we may end up picking a Python 3.X interpreter where Python 2.7 was meant to be used.
This reverts commit 477c8ce.
Before spack#23212 people could clone spack and run ``` spack unit-tests ``` while now this is not possible, since python-dateutil is a required but not vendored dependency. This change makes it not a hard requirement, i.e. it will be used if found in the current interpreter.
746d6a0 to
dc90336
Compare
Member
Author
|
Well, failure in CI it's an unfixed bug in |
sethrj
approved these changes
Jun 23, 2021
This was referenced Jun 23, 2021
Merged
Merged
Merged
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jun 29, 2021
…ed (spack#24484) * Force the Python interpreter with an env variable This commit forces the Python interpreter with an environment variable, to ensure that the Python set by the "setup-python" action is the one being used. Due to the policy adopted by Spack to prefer python3 over python we may end up picking a Python 3.X interpreter where Python 2.7 was meant to be used. * Revert "Update conftest.py (spack#24473)" This reverts commit 477c8ce. * Make python-dateutil a soft dependency for unit tests Before spack#23212 people could clone spack and run ``` spack unit-tests ``` while now this is not possible, since python-dateutil is a required but not vendored dependency. This change makes it not a hard requirement, i.e. it will be used if found in the current interpreter. * Workaround mypy complaint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications:
SPACK_PYTHONpython-dateutilnot being present in Python 2.7python-dateutilnot a hard requirement for unit tests