Merged
Conversation
adamjstewart
commented
Dec 8, 2020
| last_update = os.path.getmtime(args.update) | ||
| if not any(os.path.getmtime(f) > last_update for f in files): | ||
| tty.msg('File is up to date: %s' % args.update) | ||
| return |
Member
Author
There was a problem hiding this comment.
This logic doesn't work when a command is removed, since we can't check if a non-existent file is newer than the file to update.
alalazo
approved these changes
Dec 8, 2020
f705f24 to
10f2216
Compare
10f2216 to
69f8557
Compare
Member
Author
|
Ping @tgamblin |
alalazo
approved these changes
Jan 26, 2021
jppelteret
pushed a commit
to jppelteret/spack
that referenced
this pull request
Feb 4, 2021
spack setup was deprecated in 0.16 and will be removed in 0.17 Follow-up to spack#18240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spack setupwas deprecated in 0.16 and will be removed in 0.17.Follow-up to #18240