autotools: set 'ldlibs' as 'LIBS'#17254
Merged
becker33 merged 1 commit intospack:developfrom Aug 13, 2023
Merged
Conversation
Member
b9bc8c3 to
7977ae5
Compare
Member
Author
|
@becker33 could you, please, review this? |
7977ae5 to
53ab851
Compare
Member
Author
|
Surprisingly, this is still relevant. |
alalazo
approved these changes
Apr 4, 2023
Member
|
Maybe it gets merged earlier if you provide a reference for this |
Member
Author
|
@haampie I'm sorry, I don't understand your last message. A reference to what? That a standard Autoconf-based configure script expects the linker flags to be listed in the |
Member
|
Yeah, just a pointer to something that confirms it's the standard variable, like https://www.gnu.org/software/automake/manual/html_node/Program-Variables.html. To be honest, I've never heard of |
becker33
approved these changes
Aug 13, 2023
mpokorny
pushed a commit
to mpokorny/spack
that referenced
this pull request
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autotool configure scripts should receive
LIBSinstead ofLDLIBS.