gettext: add missing iconv dependency#16193
Merged
tgamblin merged 1 commit intospack:developfrom Apr 21, 2020
Merged
Conversation
`gettext` will pick up a random `iconv` dependency if not specified, which crashes python and its own builds on macOS.
LDAmorim
approved these changes
Apr 20, 2020
Member
Member
Author
Member
Author
|
cc @robertsawko this might fix your |
adamjstewart
approved these changes
Apr 21, 2020
Member
adamjstewart
left a comment
There was a problem hiding this comment.
Builds for me on macOS and links to the correct library.
tgamblin
approved these changes
Apr 21, 2020
This was referenced Apr 21, 2020
Merged
ax3l
commented
Apr 21, 2020
| config_args = [ | ||
| '--disable-java', | ||
| '--disable-csharp', | ||
| '--disable-icsharp', |
ReinhardPrix
pushed a commit
to ReinhardPrix/spack
that referenced
this pull request
Jul 20, 2020
`gettext` will pick up a random `iconv` dependency if not specified, which crashes python and its own builds on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gettextwill pick up a randomiconvdependency if not specified, which crashes python and its own builds on macOS.This should fix #14415 #16075 et al.
I tested building all versions on Ubuntu 18.04 but need someone to confirm this fixes your
gettextandpythonbuild issues on macOS.cc @coreyjadams @LDAmorim @gartung @adamjstewart @sethrj