Release a new version v2.1.8.0 for SZ#13974
Merged
adamjstewart merged 3 commits intospack:developfrom Dec 4, 2019
Merged
Conversation
adamjstewart
approved these changes
Dec 4, 2019
Member
Can you open an issue and paste the exact error messages? I'm surprised any of those tests are failing. But yes, it has nothing to do with your PR. |
Contributor
Author
|
I tested the 'spack test' in my own develop branch repo.
Before that, I used 'git fetch upstream' to synchronize with the official
spack.
Then, I executed the 'spack test' in the subdirectory:
var/spack/repos/builtin/packages/sz, and I got the following log. Did I do
anything wrong?
[sdi@sdihost sz]$ spack test
===============================================================================================
test session starts
===============================================================================================
platform linux -- Python 3.5.4, pytest-3.2.5, py-1.4.34, pluggy-0.4.0
rootdir: /home/sdi/Development/spack/spack-disheng222/lib/spack/spack/test,
inifile: pytest.ini
collected 2290 items
architecture.py
..............................................................
build_environment.py .........
build_system_guess.py ................
build_systems.py .............................
cc.py ..........................
cmd_extensions.py ..
compilers.py ............................................
concretize.py
.........................................................................................
concretize_preferences.py ...............
config.py .....................................
database.py ...........................
directives.py ..
directory_layout.py .....
environment_modifications.py .................................
flag_handlers.py ...........
git_fetch.py
...............................................................ss
graph.py ....
hg_fetch.py sssss
install.py ...............
mirror.py .s.
packaging.py .
patch.py .
url_fetch.py .
views.py .
cmd/activate.py ...
cmd/deprecate.py .........
cmd/env.py ............................
cmd/install.py ...................................
cmd/mirror.py ..
cmd/reindex.py ...
cmd/verify.py .
cmd/view.py ..................
install.py ....
link_paths.py ........
make_executable.py .......
mirror.py ..s.
module_parsing.py .......
multimethod.py ........................
namespace_trie.py .....
operating_system.py ...
optional_deps.py ..................
package_class.py ..
package_hash.py .......
package_sanity.py ..........
packages.py ...............................
packaging.py .....s
patch.py ..........
pattern.py ....
permissions.py ..
provider_index.py .....
python_version.py ..
relocate.py sss.
repo.py .......
sbang.py ..
schema.py ...........
spack_yaml.py ....
spec_dag.py ............................................
spec_list.py .......
spec_semantics.py
............................................................
spec_syntax.py ...........................................
spec_yaml.py ...........
stage.py ..........................................
svn_fetch.py .....
tengine.py ..
test_activations.py ........
url_fetch.py
...............................................................................................
url_parse.py
.............................................................................................................................................................................................................................
url_substitution.py .........
variant.py ............................
verification.py ......
versions.py .......................................
web.py ..........
cmd/arch.py .....
cmd/blame.py ....
cmd/build_env.py ......
cmd/buildcache.py ..
cmd/cd.py .
cmd/clean.py ......
cmd/commands.py ......
cmd/compiler_command.py .
cmd/config.py .......
cmd/create.py ...........................
cmd/debug.py .
cmd/dependencies.py .....
cmd/dependents.py ....
cmd/dev_build.py .......
cmd/env.py ..............................................
cmd/extensions.py ...
cmd/find.py .................
cmd/flake8.py .s
cmd/gpg.py .
cmd/graph.py ......
cmd/help.py x....
cmd/info.py .........
cmd/install.py ...............
cmd/license.py ..
cmd/list.py ........
cmd/location.py .................
cmd/maintainers.py ..........
cmd/module.py .....................
cmd/pkg.py .........
cmd/print_shell_vars.py ....
cmd/providers.py ........
cmd/python.py .
cmd/release_jobs.py ..
cmd/resource.py ...
cmd/spec.py ......
cmd/test_compiler_cmd.py ..
cmd/uninstall.py ........
cmd/url.py .......
cmd/verify.py .
cmd/versions.py ......
cmd/view.py .
cmd/common/arguments.py ...............
llnl/util/cpu.py
.............................................................................................................................................................................................................................................................
llnl/util/file_list.py .................................
llnl/util/filesystem.py ....................................
llnl/util/lang.py ...............
llnl/util/link_tree.py .....
llnl/util/lock.py
.........................................ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss..
llnl/util/log.py .....
modules/common.py ....
modules/lmod.py ......................
modules/tcl.py ...................
util/editor.py .........
util/environment.py .........
util/executable.py .
util/file_cache.py ..
util/log_parser.py .
util/prefix.py ....
util/spack_lock_wrapper.py ..s
util/spack_yaml.py ..
util/util_gpg.py ...
util/util_string.py .
util/util_url.py FFF.
=============================================================================================
short test summary info
=============================================================================================
FAIL util/util_url.py::test_url_parse
FAIL util/util_url.py::test_url_local_file_path
FAIL util/util_url.py::test_url_join_local_paths
SKIP [1]
/home/sdi/Development/spack/spack-disheng222/lib/spack/spack/test/util/spack_lock_wrapper.py:83:
user has no group with gid != uid
SKIP [40]
/home/sdi/Development/spack/spack-disheng222/lib/spack/spack/test/llnl/util/lock.py:151:
requires filesystem: '/nfs/tmp2/sdi'
SKIP [1] mirror.py:124: requires mercurial to be installed
SKIP [1] cmd/flake8.py:62: flake8 is not installed.
SKIP [4] hg_fetch.py:25: requires mercurial to be installed
SKIP [2]
/home/sdi/Development/spack/spack-disheng222/lib/spack/spack/test/git_fetch.py:185:
Not testing get_full_repo for older git 1.7.0
SKIP [1] packaging.py:360: only works with Mach-o objects
SKIP [40]
/home/sdi/Development/spack/spack-disheng222/lib/spack/spack/test/llnl/util/lock.py:151:
requires filesystem: '/p/lscratch*/sdi'
SKIP [3]
/home/sdi/Development/spack/spack-disheng222/lib/spack/spack/test/conftest.py:268:
could not find executables: patchelf
SKIP [1] hg_fetch.py:80: requires mercurial to be installed
SKIP [1] mirror.py:132: requires subversion, git, and mercurial to be
installed
XFAIL cmd/help.py::test_reuse_after_help
============================================================================================
slowest 20 test durations
============================================================================================
15.07s call cmd/url.py::test_url_list
10.34s call architecture.py::test_user_front_end_input
7.65s call cmd/gpg.py::test_gpg
5.75s call cmd/versions.py::test_no_unchecksummed_versions
5.30s call cmd/env.py::test_stack_view_select[mock_archive0]
4.59s call cmd/env.py::test_stack_view_multiple_views[mock_archive0]
4.58s call
cmd/env.py::test_stack_view_activate_from_default[mock_archive0]
4.49s call cmd/env.py::test_stack_combinatorial_view[mock_archive0]
4.36s call cmd/url.py::test_url_summary
4.31s call
cmd/env.py::test_stack_view_no_activate_without_default[mock_archive0]
4.31s call cmd/env.py::test_stack_view_exclude[mock_archive0]
4.09s call cmd/env.py::test_stack_view_select_and_exclude[mock_archive0]
3.94s call cmd/env.py::test_view_link_all[mock_archive0]
3.70s call packaging.py::test_buildcache[mock_archive0]
3.63s call cmd/env.py::test_view_link_roots[mock_archive0]
3.54s call cmd/extensions.py::test_extensions
3.38s call package_sanity.py::test_all_packages_use_sha256_checksums
3.27s call cmd/url.py::test_url_stats
3.23s call cmd/list.py::test_list_format_html
3.03s call package_sanity.py::test_package_version_consistency
====================================================================================================
FAILURES
=====================================================================================================
_________________________________________________________________________________________________
test_url_parse
__________________________________________________________________________________________________
def test_url_parse():
parsed = url_util.parse('/path/to/resource')
assert(parsed.scheme == 'file')
assert(parsed.netloc == '')
assert(parsed.path == '/path/to/resource')
parsed = url_util.parse('/path/to/resource', scheme='fake')
assert(parsed.scheme == 'fake')
assert(parsed.netloc == '')
assert(parsed.path == '/path/to/resource')
parsed = url_util.parse('file:///path/to/resource')
assert(parsed.scheme == 'file')
assert(parsed.netloc == '')
assert(parsed.path == '/path/to/resource')
parsed = url_util.parse('file:///path/to/resource', scheme='fake')
assert(parsed.scheme == 'file')
assert(parsed.netloc == '')
assert(parsed.path == '/path/to/resource')
parsed = url_util.parse('file://path/to/resource')
assert(parsed.scheme == 'file')
assert(parsed.netloc == '')
expected = os.path.abspath(os.path.join('path', 'to', 'resource'))
assert(parsed.path == expected)
parsed = url_util.parse('https://path/to/resource')
assert(parsed.scheme == 'https')
assert(parsed.netloc == 'path')
assert(parsed.path == '/to/resource')
spack_root = os.path.abspath(os.environ['SPACK_ROOT'])
E KeyError: 'SPACK_ROOT'
util/util_url.py:44: KeyError
____________________________________________________________________________________________
test_url_local_file_path
_____________________________________________________________________________________________
def test_url_local_file_path():
spack_root = os.path.abspath(os.environ['SPACK_ROOT'])
E KeyError: 'SPACK_ROOT'
util/util_url.py:59: KeyError
____________________________________________________________________________________________
test_url_join_local_paths
____________________________________________________________________________________________
def test_url_join_local_paths():
# Resolve local link against page URL
# wrong:
assert(
url_util.join(
's3://bucket/index.html',
'../other-bucket/document.txt')
==
's3://bucket/other-bucket/document.txt')
# correct - need to specify resolve_href=True:
assert(
url_util.join(
's3://bucket/index.html',
'../other-bucket/document.txt',
resolve_href=True)
==
's3://other-bucket/document.txt')
# same as above: make sure several components are joined together
correctly
assert(
url_util.join(
# with resolve_href=True, first arg is the base url; can
not be
# broken up
's3://bucket/index.html',
# with resolve_href=True, remaining arguments are the
components of
# the local href that needs to be resolved
'..', 'other-bucket', 'document.txt',
resolve_href=True)
==
's3://other-bucket/document.txt')
# Append local path components to prefix URL
# wrong:
assert(
url_util.join(
'https://mirror.spack.io/build_cache',
'my-package',
resolve_href=True)
==
'https://mirror.spack.io/my-package')
# correct - Need to specify resolve_href=False:
assert(
url_util.join(
'https://mirror.spack.io/build_cache',
'my-package',
resolve_href=False)
==
'https://mirror.spack.io/build_cache/my-package')
# same as above; make sure resolve_href=False is default
assert(
url_util.join(
'https://mirror.spack.io/build_cache',
'my-package')
==
'https://mirror.spack.io/build_cache/my-package')
# same as above: make sure several components are joined together
correctly
assert(
url_util.join(
# with resolve_href=False, first arg is just a prefix. No
# resolution is done. So, there should be no difference
between
# join('/a/b/c', 'd/e'),
# join('/a/b', 'c', 'd/e'),
# join('/a', 'b/c', 'd', 'e'), etc.
'https://mirror.spack.io',
'build_cache',
'my-package')
==
'https://mirror.spack.io/build_cache/my-package')
# file:// URL path components are *NOT* canonicalized
spack_root = os.path.abspath(os.environ['SPACK_ROOT'])
E KeyError: 'SPACK_ROOT'
util/util_url.py:174: KeyError
========================================================================= 3
failed, 2191 passed, 95 skipped, 1 xfailed in 290.16 seconds
==========================================================================
Best,
Sheng
…On Tue, Dec 3, 2019 at 10:35 PM Adam J. Stewart ***@***.***> wrote:
Merged #13974 <#13974> into develop.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13974?email_source=notifications&email_token=ACK3KSKMWT66WUGPW34KSS3QW4XSHA5CNFSM4JVCBG7KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVIDUQ6Y#event-2852604027>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACK3KSIDPEXVBGEUD2LOD4DQW4XSHANCNFSM4JVCBG7A>
.
|
Member
|
Interesting, it looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am releasing v2.1.8.0 for SZ, also modifying package.py by adding maintainer and parallel=False.
I ran 'spack test' but failed. However, it seems that failure has nothing to do with my modification. I just modified sz/package.py. The failures are 'test_url_parse', 'test_url_local_file_path', 'test_url_join_local_paths'.