Update URL parsing regexes and tests#13411
Merged
adamjstewart merged 8 commits intospack:developfrom Oct 29, 2019
Merged
Conversation
600f0f6 to
3eb23a3
Compare
This was referenced Oct 25, 2019
0e9c5a0 to
0ced45a
Compare
tgamblin
requested changes
Oct 28, 2019
Member
tgamblin
left a comment
There was a problem hiding this comment.
Minor change request because I'm triggered by that prefix removal copypasta. Otherwise LGTM!
|
|
||
| version( | ||
| "19.0.4-linux-rhel6-x86_64", | ||
| "19.0.4-Redhat-6.0-x86_64", |
Member
There was a problem hiding this comment.
This is kind of an unfortunate change in convention.
Member
Author
There was a problem hiding this comment.
I thought about it, and decided that when we add a when= parameter to the version() directive, all of these will become 19.0.4 anway, so it didn't really matter what we called the version. I can revert this package if you want, I don't really care.
ax3l
reviewed
Oct 28, 2019
tgamblin
approved these changes
Oct 28, 2019
1dcf416 to
5d74bee
Compare
jrmadsen
pushed a commit
to jrmadsen/spack
that referenced
this pull request
Oct 30, 2019
* Update URL parsing regexes and tests * Get rid of no longer used README * Merge py-udunits and py-cf-units * netcdf -> netcdf-c * setup_environment -> setup_*_environment * Fix doc tests * Few last minute fixes * Simplify prefix removal copypasta
SteVwonder
added a commit
to SteVwonder/spack
that referenced
this pull request
Nov 2, 2019
In spack#13411, `setup_environment` was split into `setup_build_environment` and `setup_run_environment`, with the `spack_env` and `run_env` arguments being changed to `env`. Somehow the flux package was the only one to not have its `spack_env` references in the function changed to `env`.
SteVwonder
added a commit
to SteVwonder/spack
that referenced
this pull request
Nov 2, 2019
In spack#13411, `setup_environment` was split into `setup_build_environment` and `setup_run_environment`, with the `spack_env` and `run_env` arguments being changed to `env`. Somehow the flux package was the only one to not have its `spack_env` references in the function changed to `env`.
SteVwonder
added a commit
to SteVwonder/spack
that referenced
this pull request
Nov 4, 2019
In spack#13411, `setup_environment` was split into `setup_build_environment` and `setup_run_environment`, with the `spack_env` and `run_env` arguments being changed to `env`. Somehow the flux package was the only one to not have its `spack_env` references in the function changed to `env`.
adamjstewart
pushed a commit
that referenced
this pull request
Nov 4, 2019
* flux: add `url_for_version` to support their C4 repo model Flux uses a fork of ZeroMQ's Collective Code Construction Contract (https://github.com/flux-framework/rfc/blob/master/spec_1.adoc). This model requires a repository fork for every stable release that has patch releases. For example, 0.8.0 and 0.9.0 are both tags within the main repository, but 0.8.1 and 0.9.5 would be releases on the v0.8 and v0.9 forks, respectively. * flux: add latest versions * flux: remove master from `when=@0.X:,master` statements Now that #1983 has been merged, master > 0.X.0. * flux-core: remove extraneous `99` patch version in `when` range Replace `when=@:0.11.99` with `when=@:0.11` since the intention is to include all patch versions of `0.11`. * flux-core: fix `setup_build_environment` after changes in #13411 In #13411, `setup_environment` was split into `setup_build_environment` and `setup_run_environment`, with the `spack_env` and `run_env` arguments being changed to `env`. Somehow the flux package was the only one to not have its `spack_env` references in the function changed to `env`. * flux: add runtime environment variables that Flux checks with older versions of Flux (i.e, 0.0:0.13), FLUX_CONNECTOR_PATH must be set by spack to prevent failures in certain scenarios (flux-framework/flux-core#2456). the flux binary also sets some other environment variables, which can be listed by running `flux -v start`. I added a few of those just to be sure that the Spack-installed paths are used, rather than system-installed ones. * flux: add optional testing dependencies to maximize test coverage Install optional dependencies to ensure that only spack-installed software is detected and that all tests are run when `spack install --test` is used. Flux's test suite will test for the existance of valgrind, jq, and any MPI installation. If it detects them (even if they are system-installed and outside the spack environment), it will run optional tests against them. I noticed on my machine that the valgrind tests were running against the system-install valgrind. * flux-sched: switch to new `setup_run_environment` API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tgamblin this is what happens when I get triggered 😛
Before
After