Conversation
|
I'm willing to believe this fixes #719 for this one package; but not for all Python packages, which obviously aren't affected by this PR. Is this a pattern that we should apply to other Python packages? Should we create a PythonPackage base class that incorporates this approach? So far, I've solved the general problem by |
|
@citibeth I tried spack load but wasn't able to use it due to a completely unrelated bug (see #1178). Regardless, Spack shouldn't crash when you try to install py-scipy just because you should've installed py-numpy and loaded it first. @nrichart I really like your solution. If this is a general Python thing them I'm all for incorporating it for all Python modules. Like @citibeth I would like rpaths to work for all Python packages. I wonder if we can use a global site.cfg file. Although that might make deactivating and overwriting tricky. |
|
What is the compiler that has been used to compile |
|
See PR #543 Toincorporate into all Python modules we can make a
|
|
@nrichart changes will re-add |
|
@alalazo Ah, now I see what you're saying. I can try poking around and seeing if there's some special way to get py-scipy to use the spack wrappers. But if py-scipy isn't using the spack wrappers, then I suspect most Python modules aren't. In any case, @nrichart's solution does indeed allow me to build py-scipy now! |
|
I believe Setuptools / Distutils has an --rpath option that can be used to On Thu, Jul 7, 2016 at 1:58 PM, Adam J. Stewart notifications@github.com
|
|
I try to check if it is numpy in particular or a general problem. In the case of Regular
|
|
This PR solves the problem for me. I think we should merge it for now and think about adding better RPATH support for Python packages as a whole in some kind of PythonPackage that extends BasePackage (see #1186). |
|
I have also verified that this PR solved some issues when building the python bindings for opencv due to py-numpy openblas issues. |
|
I agree, let's merge. It can only improve things. Good detective work on the blas stuff (it's sad they had to do non-standard Python setuputils stuff for want of a Fortran compiler). |
In the
site.cfg.examplethat is basically the documentation on how to link with blas you can read@citibeth this should fix #719 and help for #722