Skip to content

test: Start YAML testcases for multi-doc & other edges#556

Closed
robbat2 wants to merge 2 commits into
sourcemeta:mainfrom
robbat2:rjohnson/yaml-testcases
Closed

test: Start YAML testcases for multi-doc & other edges#556
robbat2 wants to merge 2 commits into
sourcemeta:mainfrom
robbat2:rjohnson/yaml-testcases

Conversation

@robbat2

@robbat2 robbat2 commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Start of more YAML testcases; note that the multi-doc tests fail as noted in #553.

$ for i in *yaml*sh ; do echo -n "## $i " ; bash  $i $BUILT/jsonschema-12.7.1 ; case $? in 0) echo GOOD ;; 1) echo FAIL ;; esac ; done
## fail_second_yaml.sh FAIL
## fail_second_yaml_verbose.sh FAIL
## fail_yaml.sh GOOD
## fail_yaml_linenumbers.sh GOOD
## pass_json_ref_yaml.sh GOOD
## pass_second_yaml.sh GOOD
## pass_yaml.sh GOOD
## pass_yaml_verbose.sh GOOD

Reference: #553
Signed-off-by: Robin H. Johnson rjohnson@coreweave.com

@robbat2 robbat2 force-pushed the rjohnson/yaml-testcases branch from dc73964 to 8120f32 Compare November 27, 2025 05:22
@robbat2 robbat2 mentioned this pull request Nov 27, 2025
Closed
@robbat2 @jviotti
test: Start YAML testcases for multi-doc & other edges
7477f08 
Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
@robbat2 @jviotti
test: document skipped tests
f03cb54 
While writing tests for the YAML cases; I noticed these files existed
but were not wired into CMake. For good reason, but I had to dig in the
commits to find out why. Make it easier for the next developer.

Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
@jviotti jviotti force-pushed the rjohnson/yaml-testcases branch from 8120f32 to f03cb54 Compare December 4, 2025 13:30
jviotti added a commit that referenced this pull request Dec 4, 2025
@jviotti
Support validating multi-doc YAML files
f3e0289 
Fixes: #553
Fixes: #556
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti mentioned this pull request Dec 4, 2025
Merged
@jviotti

jviotti commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Closing in favour of #577. I tried to start the work from this branch, but found some challenges rebasing it, etc given it was coming from a fork. It was easier to start over 😅 Thanks anyway!

@jviotti jviotti closed this Dec 4, 2025
jviotti added a commit that referenced this pull request Dec 4, 2025
@jviotti
Support validating multi-doc YAML files (#577)
98f263e 
Fixes: #553
Fixes: #556
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robbat2 @jviotti