Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sourcegraph/zoekt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ebb3ca2
Choose a base ref
...
head repository: sourcegraph/zoekt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 764fe4f
Choose a head ref
  • 3 commits
  • 9 files changed
  • 3 contributors

Commits on Aug 1, 2024

  1. remove SRC_EXPERIMENT_ITERATE_NGRAM_LOOKUP_LIMIT (#800) 

    After defaulting to shard merging for all inactive repos, this in fact
makes searches slightly slower. So we can remove the experiment.

Test Plan: go test
    @keegancsmith
    keegancsmith authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c01b6c7 View commit details
    Browse the repository at this point in the history

  2. feat(Search): Add support for all Apex language extensions (#799) 

    * feat(Search): Add support for all Apex language extensions

* clean up comment

* Fix typo
    @mmanela
    mmanela authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    bbd1fed View commit details
    Browse the repository at this point in the history

  3. index: enable shard merging by default (#798) 

    This enables shard merging by default for zoekt-sourcegraph-indexserver.

Sourcegraph has been using shard merging in production for several years. We have recently confirmed significant performance improvements for queries which are bound by matchTree construction.

I also remove -merge_max_priority because we have stopped using it.

Use SRC_DISABLE_SHARD_MERGING to disable shard merging.

Test plan:
mostly CI, I did some manual testing to confirm that shard merging is enabled by default for zoekt-sourcegraph-indexserver.
    @stefanhengl
    stefanhengl authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    764fe4f View commit details
    Browse the repository at this point in the history
Loading