Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sourcegraph/zoekt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7643f3b313a2
Choose a base ref
...
head repository: sourcegraph/zoekt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 45f608ff95bd
Choose a head ref
  • 8 commits
  • 20 files changed
  • 4 contributors

Commits on Jun 29, 2023

  1. Configuration menu
    Copy the full SHA
    a176bde View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Fix template documentation comments (#610)

    The variable is `Version`, not `Branch`, and if we're using the template
    variable syntax, it should have the leading dot that it needs to.
    isker authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    e2e8aed View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. all: observe missing Stats RegexpsConsidered and FlushReason (#611)

    Noticed we didn't include these fields in our prometheus and logging
    integration.
    
    Test Plan: go test ./...
    keegancsmith authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    25c1ea5 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. zoekt-indexserver: Prevent invalid config from causing an NPE (#612)

    When the user specifies an invalid mirror config that contains an entry
    without any of the GithubUser / GithubOrg / ... repository definitions,
    zoekt-indexserver would crash, because `cmd` stays `nil` and causes a
    SIGSEGV when it is later accessed in `main.executeMirror`.
    philwo authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9abbb8b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. zoekt-indexserver: use value format directive for bad conf warning

    Test Plan: go test ./...
    keegancsmith committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    008a775 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. zoekt: add fgprof for full profiling (#614)

    Useful in local testing to capture both on and off cpu time spent.
    Should consider shipping this in the webserver as well.
    
    Test Plan: ran zoekt with -full_profile flag and inspected output in
    pprof.
    keegancsmith authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f9d3a0e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. remove ngram offset code (#616)

    We have been running btree as the default for many months. We worried
    about a performance hit, but it never happened. After some recent local
    testing I did I noticed the btree actually interacted with the disk more
    efficiently. So the old code both uses more memory and is slower, lets
    just remove it.
    
    Test Plan: go test ./...
    keegancsmith authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3d0bdd5 View commit details
    Browse the repository at this point in the history
  2. sort ngrams before looking them up (#617)

    We believe this will improve performance of the btree lookups. We are
    investigating this to make it faster to rule out a shard (when freq==0).
    Testing locally on a large corpus we halved the time spent in IO.
    
    Locally Sort shows up in the profiles significantly, but there are two
    facts mitigating that:
    - Locally my file page cache is primed so IO rarely is going to disk.
    - We likely will implement an IR for Zoekt which will amortize the Sort
      to once per search rather than once per shard.
    
    Test Plan: go test ./... and performance profiling via via ./cmd/zoekt.
    
    Co-authored-by: Stefan Hengl <stefan@sourcegraph.com>
    keegancsmith and stefanhengl authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    45f608f View commit details
    Browse the repository at this point in the history
Loading