-
Notifications
You must be signed in to change notification settings - Fork 215
Comparing changes
Open a pull request
base repository: sourcegraph/zoekt
base: 7643f3b313a2
head repository: sourcegraph/zoekt
compare: 45f608ff95bd
- 8 commits
- 20 files changed
- 4 contributors
Commits on Jun 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a176bde - Browse repository at this point
Copy the full SHA a176bdeView commit details
Commits on Jul 10, 2023
-
Fix template documentation comments (#610)
The variable is `Version`, not `Branch`, and if we're using the template variable syntax, it should have the leading dot that it needs to.
Configuration menu - View commit details
-
Copy full SHA for e2e8aed - Browse repository at this point
Copy the full SHA e2e8aedView commit details
Commits on Jul 11, 2023
-
all: observe missing Stats RegexpsConsidered and FlushReason (#611)
Noticed we didn't include these fields in our prometheus and logging integration. Test Plan: go test ./...
Configuration menu - View commit details
-
Copy full SHA for 25c1ea5 - Browse repository at this point
Copy the full SHA 25c1ea5View commit details
Commits on Jul 12, 2023
-
zoekt-indexserver: Prevent invalid config from causing an NPE (#612)
When the user specifies an invalid mirror config that contains an entry without any of the GithubUser / GithubOrg / ... repository definitions, zoekt-indexserver would crash, because `cmd` stays `nil` and causes a SIGSEGV when it is later accessed in `main.executeMirror`.
Configuration menu - View commit details
-
Copy full SHA for 9abbb8b - Browse repository at this point
Copy the full SHA 9abbb8bView commit details
Commits on Jul 13, 2023
-
zoekt-indexserver: use value format directive for bad conf warning
Test Plan: go test ./...
Configuration menu - View commit details
-
Copy full SHA for 008a775 - Browse repository at this point
Copy the full SHA 008a775View commit details
Commits on Jul 14, 2023
-
zoekt: add fgprof for full profiling (#614)
Useful in local testing to capture both on and off cpu time spent. Should consider shipping this in the webserver as well. Test Plan: ran zoekt with -full_profile flag and inspected output in pprof.
Configuration menu - View commit details
-
Copy full SHA for f9d3a0e - Browse repository at this point
Copy the full SHA f9d3a0eView commit details
Commits on Jul 17, 2023
-
remove ngram offset code (#616)
We have been running btree as the default for many months. We worried about a performance hit, but it never happened. After some recent local testing I did I noticed the btree actually interacted with the disk more efficiently. So the old code both uses more memory and is slower, lets just remove it. Test Plan: go test ./...
Configuration menu - View commit details
-
Copy full SHA for 3d0bdd5 - Browse repository at this point
Copy the full SHA 3d0bdd5View commit details -
sort ngrams before looking them up (#617)
We believe this will improve performance of the btree lookups. We are investigating this to make it faster to rule out a shard (when freq==0). Testing locally on a large corpus we halved the time spent in IO. Locally Sort shows up in the profiles significantly, but there are two facts mitigating that: - Locally my file page cache is primed so IO rarely is going to disk. - We likely will implement an IR for Zoekt which will amortize the Sort to once per search rather than once per shard. Test Plan: go test ./... and performance profiling via via ./cmd/zoekt. Co-authored-by: Stefan Hengl <stefan@sourcegraph.com>
Configuration menu - View commit details
-
Copy full SHA for 45f608f - Browse repository at this point
Copy the full SHA 45f608fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7643f3b313a2...45f608ff95bd