remove ngram offset code#616
Merged
Merged
Conversation
We have been running btree as the default for many months. We worried about a performance hit, but it never happened. After some recent local testing I did I noticed the btree actually interacted with the disk more efficiently. So the old code both uses more memory and is slower, lets just remove it. Test Plan: go test ./...
This is no longer needed, we always use the btree. Additionally I added some documentation.
stefanhengl
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been running btree as the default for many months. We worried about a performance hit, but it never happened. After some recent local testing I did I noticed the btree actually interacted with the disk more efficiently. So the old code both uses more memory and is slower, lets just remove it.
Test Plan: go test ./...