Scj/update/executor validate#974
Merged
Merged
Conversation
jasonhawkharris
approved these changes
Apr 24, 2023
jasonhawkharris
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I made one note about preferences but I think the note generally lines up with convention.
added 2 commits
April 24, 2023 10:59
camdencheek
pushed a commit
that referenced
this pull request
Apr 24, 2023
* add executor option for src validate install * remove commented code, remove option * remove binary * lint * update error int to -1
camdencheek
pushed a commit
that referenced
this pull request
Apr 24, 2023
* add executor option for src validate install * remove commented code, remove option * remove binary * lint * update error int to -1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
executor.enabled: trueto vaildate.yaml will check live executor connections