Skip to content

Scj/update/smtp validate#973

Merged
scjohns merged 6 commits into
mainfrom
scj/update/smtp-validate
Apr 24, 2023
Merged

Scj/update/smtp validate#973
scjohns merged 6 commits into
mainfrom
scj/update/smtp-validate

Conversation

@scjohns

@scjohns scjohns commented Apr 21, 2023

Copy link
Copy Markdown
Contributor

Test plan

  • Validate that adding smtp configs to a validation.yaml file will attempt to send a test
  • Validate that not including smtp in validation.yaml does not trigger an attempt to send a test

@scjohns scjohns requested a review from jdpleiness April 21, 2023 14:52

@jasonhawkharris jasonhawkharris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scjohns scjohns merged commit 1ef7956 into main Apr 24, 2023
@scjohns scjohns deleted the scj/update/smtp-validate branch April 24, 2023 14:56
scjohns added a commit that referenced this pull request Apr 24, 2023
* add config for smtp

* add function for smtp

* smtp enabled check

* lint

* change Smtp.Test to Smtp.Enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants