Implement CLI for ingested codeowners#943
Merged
Merged
Conversation
This requires some backend changes that I proposed on the schema PR, but it might help with testing the implementation.
leonore
reviewed
Mar 3, 2023
leonore
left a comment
Contributor
There was a problem hiding this comment.
spotted a mismatch with main!
Comment on lines
+46
to
+54
| query := `mutation DeleteCodeownersFile( | ||
| $repoName: String!, | ||
| ) { | ||
| deleteCodeownersFiles(repositories: [{ | ||
| repoName: $repoName, | ||
| }]) { | ||
| alwaysNil | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I think this isn't up to date with main anymore, it takes a slice (just in case we wanted an admin UI with it)
go run ./cmd/src codeowners delete -repo 'github.com/leonore/sourcegraph-test'
GraphQL errors: 2 errors occurred:
* {
"locations": [
{
"column": 24,
"line": 4
}
],
"message": "Unknown argument \"repositories\" on field \"deleteCodeownersFiles\" of type \"Mutation\"."
}
* {
"locations": [
{
"column": 2,
"line": 4
}
],
"message": "Field \"deleteCodeownersFiles\" argument \"repositoryIDs\" of type \"[Int!]!\" is required but not provided."
}
exit status 1
Member
Author
There was a problem hiding this comment.
did you try it as of https://github.com/sourcegraph/sourcegraph/pull/48584?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires https://github.com/sourcegraph/sourcegraph/pull/48584.
Closes https://github.com/sourcegraph/sourcegraph/issues/47823.
Test plan
Verified with the new backend endpoints.