[language-platform] update src-cli to handle scip file upload#897
Conversation
efritz
left a comment
There was a problem hiding this comment.
LGTM. I'd like to run it by hand though once we have some of the changes to sg/sg landed before this lands as well.
# Conflicts: # go.mod # go.sum
|
@Numbers88s There's a point where we try to read the metadata vertex from the LSIF file to get the indexer name/version. We should also support reading this from the Metadata message in a SCIP proto file. Can you find out where that is and modify it as well? |
|
Please review and merge #907 into this branch before landing. We also need a changelog entry. |
|
@Numbers88s I made a few updates in #911 that target this branch. This change makes the default file value include SCIP files if there's no ambiguity. I tested all four scenarios (instance does/doesn't accept scip vs. scip/lsif upload file) and everything seems good. @Numbers88s Could you add an item to the CHANGELOG and then I think we can get read to merge this after we've updated the codeintel-qa to use SCIP directly (check for any last minute holes we can plug before we start rewriting data in production). |
| All notable changes to `src-cli` are documented in this file. | ||
|
|
||
| ## Unreleased | ||
| ## Unreleased (4.5) |
There was a problem hiding this comment.
- Merge after 4.4 is released, update changelog.
Fixes https://github.com/sourcegraph/sourcegraph/issues/45078
Before this PR src codeintel upload would translate a SCIP file to LSIF prior to upload. With this PR it now instead checks with the instance to see if it can handle SCIP uploads. This is done with a HEAD request to the upload endpoint it then updates the headers to reflect the SCIP metadata.
Test plan
To test properly you will need the changes from this PR https://github.com/sourcegraph/sourcegraph/pull/45269
go.modin this repo to point to your local environment with the changes above.Example:
replace github.com/sourcegraph/sourcegraph/lib => /Users/<YOUR NAME>/go/src/sourcegraph/libgo buildinside the src-cli/cmd/src directorysourcegraph/sourcegraph/client/webAt the moment, the instance cannot handle SCIP. But this PR (https://github.com/sourcegraph/sourcegraph/pull/45104) should handle that part.