Improve log output of docker pull errors#880
Merged
Merged
Conversation
Recently a customer ran into _some_ issue but we weren't able to tell WHAT the issue was. This adds additional log output. *Before* ``` ✅ Parsing batch spec ✅ Resolving namespace ⠸ Preparing container images 0% ❌ Error: pulling image "ubunootu:18.04": pulling image: exit status 1 💡 The troubleshooting documentation can help to narrow down the cause of the errors: https://docs.sourcegraph.com/batch_changes/references/troubleshooting ``` *After* ``` ✅ Parsing batch spec ✅ Resolving namespace ⠏ Preparing container images 0% ❌ Error: pulling image "ubunootu:18.04": failed to pull image: Error response from daemon: failed to resolve reference "docker.io/library/ubunootu:18.04": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed docker pull exited with code 1 💡 The troubleshooting documentation can help to narrow down the cause of the errors: https://docs.sourcegraph.com/batch_changes/references/troubleshooting ```
BolajiOlajide
approved these changes
Nov 6, 2022
courier-new
approved these changes
Nov 7, 2022
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Great improvement. 🙂
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Recently a customer ran into _some_ issue but we weren't able to tell WHAT the issue was. This adds additional log output. *Before* ``` ✅ Parsing batch spec ✅ Resolving namespace ⠸ Preparing container images 0% ❌ Error: pulling image "ubunootu:18.04": pulling image: exit status 1 💡 The troubleshooting documentation can help to narrow down the cause of the errors: https://docs.sourcegraph.com/batch_changes/references/troubleshooting ``` *After* ``` ✅ Parsing batch spec ✅ Resolving namespace ⠏ Preparing container images 0% ❌ Error: pulling image "ubunootu:18.04": failed to pull image: Error response from daemon: failed to resolve reference "docker.io/library/ubunootu:18.04": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed docker pull exited with code 1 💡 The troubleshooting documentation can help to narrow down the cause of the errors: https://docs.sourcegraph.com/batch_changes/references/troubleshooting ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently a customer ran into some issue but we weren't able to tell WHAT the issue was. This adds additional log output.
Before
After
Test plan
Verified output looks good.