batches: Remote Mount #5 - src-cli#816
Merged
Merged
Conversation
eseliger
approved these changes
Oct 4, 2022
| "github.com/sourcegraph/sourcegraph/lib/batches" | ||
| ) | ||
|
|
||
| func TestService_UploadBatchSpecWorkspaceFiles_Windows_Path(t *testing.T) { |
Member
There was a problem hiding this comment.
the fact that this test has to exist makes me sad 🙃
Contributor
Author
There was a problem hiding this comment.
lol, I had a dream about windows paths. This is the result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #31792.
Dependent on sourcegraph#40932.
remotecommand uploads files specified in themountsection of astep. The files are upload via the files API.execentry command to accept the flagworkspaceFilesand to mount this directory when running DockerTest plan
Go Unit tests and functional testing. Running mounts locally also confirmed to still work.
Example
Screen.Recording.2022-09-21.at.19.39.11.mov