batches: add SRC_HEADERS for passing multiple custom headers#796
Merged
Conversation
LawnGnome
approved these changes
Jun 29, 2022
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
Couple of trivial nits, but LGTM otherwise.
Not a blocker, but probably worth at least thinking slightly about: do we have any idea how this would go on Windows? If the answer is "it won't work", that's fine, but we should probably call it out in WINDOWS.md.
Piszmog
approved these changes
Jun 29, 2022
Co-authored-by: Adam Harvey <adam@adamharvey.name>
df0abc9 to
c9070ac
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Co-authored-by: Adam Harvey <adam@adamharvey.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
Closes #749