Skip to content

batches: upsert batch change when running `src batch remote#787

Merged
BolajiOlajide merged 6 commits into
mainfrom
bo/upsert-batch-change
Jun 17, 2022
Merged

batches: upsert batch change when running `src batch remote#787
BolajiOlajide merged 6 commits into
mainfrom
bo/upsert-batch-change

Conversation

@BolajiOlajide

Copy link
Copy Markdown
Contributor

Closes #780

Test plan

  • Create a server-side batch change with the command src batch remote
  • When the command is done, the batch change should be accessible via the execution link outputted in the terminal

@BolajiOlajide BolajiOlajide self-assigned this Jun 16, 2022
@BolajiOlajide BolajiOlajide changed the title upsert batch change when running `src batch remote batches: upsert batch change when running `src batch remote Jun 16, 2022
@BolajiOlajide BolajiOlajide requested a review from a team June 16, 2022 02:49
@BolajiOlajide BolajiOlajide force-pushed the bo/upsert-batch-change branch from fe98fd9 to 69b07a9 Compare June 16, 2022 17:11
Comment thread cmd/src/batch_remote.go

@courier-new courier-new left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Comment thread internal/batches/service/remote.go

@LawnGnome LawnGnome left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Comment thread cmd/src/batch_remote.go
Comment thread CHANGELOG.md Outdated
BolajiOlajide and others added 2 commits June 16, 2022 18:52
Co-authored-by: Adam Harvey <adam@adamharvey.name>
@BolajiOlajide BolajiOlajide merged commit 96335e5 into main Jun 17, 2022
@BolajiOlajide BolajiOlajide deleted the bo/upsert-batch-change branch June 17, 2022 00:33
scjohns pushed a commit that referenced this pull request Apr 24, 2023
* upsert batch change when running `src batch remote

* use batchChangeName for execution url

* update changelog

* add createBatchSpecFromRaw query

* Update CHANGELOG.md

Co-authored-by: Adam Harvey <adam@adamharvey.name>

* remove redundant UpsertBatchSpecInput method

Co-authored-by: Adam Harvey <adam@adamharvey.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSBC: src batch remote preview link returns 404 if batch change did not already exist

5 participants