Skip to content

batches: ensure .gitconfig email is properly inserted in batch spec#773

Merged
BolajiOlajide merged 2 commits into
mainfrom
bo/fetch-global-git-email-plain-text
Jun 8, 2022
Merged

batches: ensure .gitconfig email is properly inserted in batch spec#773
BolajiOlajide merged 2 commits into
mainfrom
bo/fetch-global-git-email-plain-text

Conversation

@BolajiOlajide

@BolajiOlajide BolajiOlajide commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

In src-cli, we use the html/template library to substitute values, however, characters like + gets converted to it's unicode equivalent &043;

Before
CleanShot 2022-06-08 at 12 03 09@2x

After
CleanShot 2022-06-08 at 11 57 31@2x

Test plan

  • Enable email privacy on your Github account.
    CleanShot 2022-06-08 at 11 40 23@2x
  • Set your github-private email address in your global config with the command
git config --global add user.email <private_email_address>
  • Create a batch spec with the command src batch new -f batch.spec.yml
  • The email address should be inserted into the template as plain text instead of unicode.

@BolajiOlajide BolajiOlajide requested a review from a team June 8, 2022 10:06
@BolajiOlajide BolajiOlajide self-assigned this Jun 8, 2022

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW that must've taken forever to find 😨

@BolajiOlajide

Copy link
Copy Markdown
Contributor Author

WOW that must've taken forever to find 😨

I was almost pulling my hair out at some point lol. Thankfully, all I needed was a 30-minute nap and I immediately checked the template import lol.

@BolajiOlajide BolajiOlajide merged commit 17dd444 into main Jun 8, 2022
@BolajiOlajide BolajiOlajide deleted the bo/fetch-global-git-email-plain-text branch June 8, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants