Skip to content

Simplify npm package release by setting the version#763

Merged
olafurpg merged 1 commit into
mainfrom
olafurpg/npm-release
Jun 3, 2022
Merged

Simplify npm package release by setting the version#763
olafurpg merged 1 commit into
mainfrom
olafurpg/npm-release

Conversation

@olafurpg

@olafurpg olafurpg commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

Previously, you had to manually open a PR to bump up the version in package.json.
Now, the version is automatically bumped during the release pipeline.

Test plan

Cut a new release and see if it works.

Previously, you had to manually open a PR to bump up the version in package.json.
Now, the version is automatically bumped during the release pipeline.
@olafurpg olafurpg requested a review from eseliger June 2, 2022 14:12
Comment thread release.sh
read -p 'Have you read DEVELOPMENT.md? [y/N] ' -n 1 -r
echo
case "$REPLY" in
Y|y) ;;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this is still getting formatted on file save when I've disabled format-on-save for all languages but go 😢

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️, honestly 😄

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick improvement!

Comment thread release.sh
read -p 'Have you read DEVELOPMENT.md? [y/N] ' -n 1 -r
echo
case "$REPLY" in
Y|y) ;;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️, honestly 😄

@olafurpg olafurpg merged commit ad9dbba into main Jun 3, 2022
@olafurpg olafurpg deleted the olafurpg/npm-release branch June 3, 2022 06:20
@olafurpg

olafurpg commented Jun 3, 2022

Copy link
Copy Markdown
Contributor Author

Cut a new patch release 3.40.5

https://github.com/sourcegraph/src-cli/actions/runs/2432861873

scjohns pushed a commit that referenced this pull request Apr 24, 2023
Previously, you had to manually open a PR to bump up the version in package.json.
Now, the version is automatically bumped during the release pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants