add login into command list & alphabetize #713
Conversation
| extensions,ext manages extensions (experimental) | ||
| batch manages batch changes | ||
| lsif manages LSIF data | ||
| login authenticate to a Sourcegraph instance with your user credentials |
There was a problem hiding this comment.
Although this looks visually aligned on an 8 space tab width, the other lines actually use spaces rather than tabs between the command name and the description (ie between login and authenticate in this case). Would you be able to change this to match the other lines with spaces, please? (Alternatively, I'm happy to do it and push it to your branch, if you'd prefer!)
There was a problem hiding this comment.
Hello @LawnGnome 👋 Thanks for having a look! Hmm, I added the line with spaces and double checked the file in VSC just now. It looks like there are spaces versus tabs, but perhaps I'm missing something? 🤔
If I did, could you let me know where the issue is and I am happy to fix it 😸
There was a problem hiding this comment.
@northyg This is what I see when I check out your branch:

It looks like it's still using 2 tabs instead of 11 spaces, and the list is not alphabetized as shown in your picture 🤔
There was a problem hiding this comment.
@LawnGnome Aha! @abeatrix and I figured out the problem. I got turned around in the other branch I had made, and didn't push the changes correctly. 🐝 Helped me sort it out. I also made an addition to the Changelog. Can you have a look and see if its good to go ?
|
Thanks for doing this! (Deferring the review to Adam) |
abeatrix
left a comment
There was a problem hiding this comment.
LGTM, great job! Let me know if you have questions regarding the formatting issue Adam has mentioned above, happy to help!
|
Thanks @abeatrix 😄 ! I re-checked the file and replied above. 🤔 |
|
Hey @northyg I just replied above. I'm wondering if we are seeing the unchanged file because you haven't pushed your local changes into the branch? |
* add login into command list * correctly push file changes

Fixes https://github.com/sourcegraph/sourcegraph/issues/32450 and adds a bit more!
Test plan
logincommand to the list