batches: make -f optional#687
Merged
Merged
Conversation
eseliger
approved these changes
Feb 1, 2022
Co-authored-by: Erik Seliger <erikseliger@me.com>
34 tasks
Closed
5 tasks
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Co-authored-by: Erik Seliger <erikseliger@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New behaviour (assuming
COMMANDis any command that accepted-f, includingapply,preview,repos, orvalidate):src batch COMMANDon a TTY: will wait for 250ms in case there's input on stdin; otherwise errorssrc batch COMMANDwith a file redirected in: waits indefinitely for inputsrc batch COMMAND -f -: waits indefinitely for inputsrc batch COMMAND FILE: reads fromFILE; equivalent tosrc batch COMMAND -f FILEsrc batch COMMAND -f FILE: works as beforeIn summary, this shouldn't break backward compatibility in any case except for the user slowly typing in a batch spec on stdin.
Fixes #680.