Backport fix for workspace globbing#664
Merged
Merged
Conversation
LawnGnome
approved these changes
Nov 26, 2021
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
Approved, but same caveat as the main repo approval.
mrnugget
approved these changes
Nov 29, 2021
| for _, conf := range spec.Workspaces { | ||
| g, err := glob.Compile(conf.In) | ||
| in := conf.In | ||
| // Empty `in` should fall back to matching all, instead of nothing. |
Contributor
There was a problem hiding this comment.
Nitpick, but just wanted to mention it: we could also define something like
type allMatcher struct{}
func (a allMatcher) Match(_ string) bool { return true }and pass that in when in == "" since it satifies glob.Glob. We'd save a glob.Compile.
See https://github.com/sourcegraph/sourcegraph/pull/28230 for more details.
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
2296e25 to
f97f54d
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/sourcegraph/sourcegraph/pull/28230 for more details.