batches: fix feature detection in src batch validate#577
Merged
Conversation
When creating the `Service` instance, `src batch validate` failed to request or initialise the Sourcegraph feature flags based on the Sourcegraph version in use. As a result, only baseline features were enabled when parsing and validating batch specs. Fixes #576.
eseliger
approved these changes
Aug 12, 2021
Comment on lines
+44
to
+50
| svc := service.New(&service.Opts{ | ||
| Client: cfg.apiClient(apiFlags, flagSet.Output()), | ||
| }) | ||
|
|
||
| if err := svc.DetermineFeatureFlags(ctx); err != nil { | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
Just a side-note, no action required: It'd be nice if this is not something that can be forgotten 😬
package service
func NewWithFeatureFlags(client *api.Client) (Service, error) {
svc := service.New(&service.Opts{
Client: client,
})
err := svc.DetermineFeatureFlags(ctx)
return svc, err
}
Contributor
Author
There was a problem hiding this comment.
Yeah, I was on the fence on this one too. I think I'd rather keep this PR as trivial as it is for now, but we might want to rethink in general how we design and couple the service at some point, since it's not as simple as it once was.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
When creating the `Service` instance, `src batch validate` failed to request or initialise the Sourcegraph feature flags based on the Sourcegraph version in use. As a result, only baseline features were enabled when parsing and validating batch specs. Fixes #576.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating the
Serviceinstance,src batch validatefailed to request or initialise the Sourcegraph feature flags based on the Sourcegraph version in use. As a result, only baseline features were enabled when parsing and validating batch specs.Fixes #576.