Support -insecure-skip-verify flag for LSIF upload#559
Merged
Conversation
Contributor
Author
|
Note tests are failing due to |
coury-clark
approved these changes
Jun 25, 2021
| client := api.NewClient(api.ClientOpts{ | ||
| Flags: lsifUploadFlags.apiFlags, | ||
| }) | ||
|
|
Contributor
There was a problem hiding this comment.
It might be a good idea to log a warning if the client is initialized without TLS validation.
Contributor
Author
There was a problem hiding this comment.
Thats a good idea, I'll follow up with a separate PR for that, as those changes would be more wide-reaching across teams 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we previously used a different API client as was provided in the src-cli codebase, we did not take into account the
-skip-insecure-verifyflag. This affected a customer as they used self-signed certs.This PR passes the src-cli configured API client that honours the flag to the LSIF upload function that resides in sg/sg/lib. The only part of the API client that is consumed is the direct pass-through method, Do(...)
Related to https://github.com/sourcegraph/sourcegraph/pull/22399 and will require bumping go.mod here when it is merged.
cc @efritz for 👀 after PTO