refactor: Pass *Task directly to runSteps#546
Merged
Conversation
This is a tiny follow-up to #540 and removes the TODO that Adam confirmed in his review.
courier-new
approved these changes
May 26, 2021
courier-new
left a comment
Contributor
There was a problem hiding this comment.
That's so much nicer, great call! 😄
eseliger
approved these changes
May 26, 2021
LawnGnome
approved these changes
May 27, 2021
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
If there was ever an argument for loose coupling of task and the executor, it went out the window when we copied damn near every field on the task into the options anyway. Good thinking!
Contributor
Author
Yeah, I also think of the executor now more as "the thing that executes tasks" vs. "the thing that executes steps", now with the |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This is a tiny follow-up to #540 and removes the TODO that Adam confirmed in his review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny follow-up to #540 and removes the TODO that Adam confirmed in his review.
It simplifies things by passing
*Taskdirectly torunSteps.