batches: make published field optional#538
Merged
Merged
Conversation
mrnugget
approved these changes
May 17, 2021
eseliger
approved these changes
May 17, 2021
courier-new
reviewed
May 17, 2021
chrispine
approved these changes
May 18, 2021
07691e3 to
87bd905
Compare
Contributor
Author
|
I've rebased this on main, which required undoing a change @mrnugget had made to remove the full feature flag struct from the co-ordinator. Alas. Otherwise, the rebase was fairly mechanical. In spite of having some rebase pain from leaving this open the first time, I've chosen not to learn from my mistakes, and will hold off on merging this for two reasons, though:
I expect to hit merge on this on Thursday or Friday. |
87bd905 to
23a2751
Compare
eseliger
approved these changes
Jun 23, 2021
The first part of sourcegraph/sourcegraph#18277.
23a2751 to
7353340
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
The first part of sourcegraph/sourcegraph#18277.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first part of sourcegraph/sourcegraph#18277.