Skip to content

Ask user for confirmation before deleting all users#470

Merged
mrnugget merged 2 commits into
mainfrom
mrn/user-delete-confirmation
Feb 17, 2021
Merged

Ask user for confirmation before deleting all users#470
mrnugget merged 2 commits into
mainfrom
mrn/user-delete-confirmation

Conversation

@mrnugget

Copy link
Copy Markdown
Contributor

This fixes https://github.com/sourcegraph/sourcegraph/issues/17859 by asking the user for confirmation before deleting all users on an instance.

@mrnugget mrnugget requested review from a team and emidoots February 16, 2021 16:03

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5128

@LawnGnome LawnGnome left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh jeez. 🙈

@mrnugget mrnugget merged commit 069b0c3 into main Feb 17, 2021
@mrnugget mrnugget deleted the mrn/user-delete-confirmation branch February 17, 2021 09:15
scjohns pushed a commit that referenced this pull request Apr 24, 2023
* Ask user for confirmation before deleting all users

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'src users delete' should prompt before deleting large number of users

3 participants