Alternative approach to keeping archives cached#450
Merged
Conversation
eseliger
approved these changes
Feb 1, 2021
eseliger
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for taking this on 👍
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Alternative approach to keeping archives cached * Rename internal properties of RepoFetcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second, alterantive approach to #449 for keeping archives cached across different executions.
It models
RepoZipas a thunk in a way:RepoFetcher.Checkout()returns aRepoZipthat's passed around with theTask. Once allTaskshave calledFetch()andClose()only then the archive is cleaned up.