ci: migrate all CI to GitHub Actions#415
Merged
Merged
Conversation
GitHub Actions can now do everything AppVeyor could for us, and more (macOS support), and less jankily (_why_ can't go test invocations call back into themselves, only on AppVeyor?).
11 tasks
mrnugget
approved these changes
Jan 4, 2021
mrnugget
left a comment
Contributor
There was a problem hiding this comment.
Ah, this is nice. Yes, let's do it.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
GitHub Actions can now do everything AppVeyor could for us, and more (macOS support), and less jankily (_why_ can't go test invocations call back into themselves, only on AppVeyor?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some Windows CI issues on #412, and it got me thinking. Nature abhors a monoculture, but GitHub Actions can now do everything AppVeyor could for us, and more (macOS support), and less jankily (why can't
go testinvocations call back into themselves, only on AppVeyor?), and we're not really tying ourselves to it any more, since we're just executinggo test. Why not unify everything on GitHub Actions?(As a bonus, this also means that my shiny new tests in #412 will pass, but I promise that's not the only reason I'm doing this.)
This will fail CI right now because AppVeyor will try to build even without an
appveyor.yml, but everything else should pass. If so, I think we should go ahead and do this.