Use api.Client for http request in src version#411
Merged
Conversation
This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically
LawnGnome
approved these changes
Dec 16, 2020
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
This is probably worth a changelog entry, but otherwise this LGTM.
chrispine
approved these changes
Dec 16, 2020
chrispine
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick turnaround!
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically