Actually skip unsupported repos if -allow-unsupported is not set#403
Merged
Conversation
I think multiple changes to this method lead to a regression where unsupported repositories were correctly being reported as unsupported but were still added to the final list of repositories, regardless of whether `-allow-unsupported` was set or not.
eseliger
approved these changes
Dec 11, 2020
eseliger
left a comment
Member
There was a problem hiding this comment.
Nice finally a test for this!
37 tasks
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Actually skip unsupported repos if -allow-unsupported is not set I think multiple changes to this method lead to a regression where unsupported repositories were correctly being reported as unsupported but were still added to the final list of repositories, regardless of whether `-allow-unsupported` was set or not. * Add PR URL to changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think multiple changes to this method lead to a regression where
unsupported repositories were correctly being reported as unsupported
but were still added to the final list of repositories, regardless of
whether
-allow-unsupportedwas set or not.