Add -skip-errors flag to src campaign apply|preview#395
Merged
Conversation
755264b to
e5efdd6
Compare
e5efdd6 to
47c0ea5
Compare
eseliger
approved these changes
Nov 24, 2020
LawnGnome
approved these changes
Nov 24, 2020
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Note: I made the conscious decision to only skip "runtime errors", i.e.: we can skip the failed step execution, or we can skip the failed importing of a changeset (see "after" screenshot). That means validation errors etc. are not skipped. Because I don't think that makes sense.
Agreed. This is only about things the user isn't necessarily in direct control of — validation errors, server errors, etc, shouldn't be subject to this.
33 tasks
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Add -skip-errors flag to src campaign apply|preview * Fix formatting of errors * Add notice * Remove notice * Add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/sourcegraph/sourcegraph/issues/15790 by adding the
-skip-errorsflag.Note: I made the conscious decision to only skip "runtime errors", i.e.: we can skip the failed step execution, or we can skip the failed importing of a changeset (see "after" screenshot). That means validation errors etc. are not skipped. Because I don't think that makes sense.
Before
After