if namespace is omitted, default to username#372
Merged
Conversation
chrispine
commented
Nov 11, 2020
eseliger
approved these changes
Nov 11, 2020
eseliger
left a comment
Member
There was a problem hiding this comment.
LGTM, besides your nil check
Co-authored-by: Erik Seliger <erikseliger@me.com>
…-cli into cp/use-default-namespace
mrnugget
approved these changes
Nov 12, 2020
Contributor
There was a problem hiding this comment.
Approve so. you can merge it after you've done it, but
- please add a changelog entry!
Before you merge your documentation changes in sourcegraph/sourcegraph:
- merge this
- release a new src-cli version (see
DEVELOPMENT.md) - make sure to bump the version in
sourcegraph/sourcegraph
🌶 Hot Pro Tip: 🌶 include the version bump in our documentation PR so that the docs are updated with the bump.
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* if namespace is omitted, default to username * just fetch the ID and do not worry about the username * remove -namespace from help text * Update internal/campaigns/service.go Co-authored-by: Erik Seliger <erikseliger@me.com> * explain the default * cannot return a nil for a string * Update cmd/src/campaigns_common.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * Update internal/campaigns/service.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * Update cmd/src/campaigns_apply.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * Update internal/campaigns/service.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * added CHANGELOG entry Co-authored-by: Erik Seliger <erikseliger@me.com> Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial fix for https://github.com/sourcegraph/sourcegraph/issues/15058