Follow-up to gzip encoding of request body#343
Merged
Conversation
Merged
chrispine
reviewed
Oct 13, 2020
| "github.com/Masterminds/semver" | ||
| "github.com/hashicorp/go-multierror" | ||
| "github.com/jig/teereadcloser" | ||
| ioaux "github.com/jig/teereadcloser" |
There was a problem hiding this comment.
It looks like goimports is what keeps adding the ioaux alias.
Contributor
Author
There was a problem hiding this comment.
And I think it's correct, since the package defined in teereadcloser is called ioaux: https://github.com/jig/teereadcloser/blob/953720c48e058a8869b07daa7db756dc7823b2e1/teereadcloser.go#L5
|
Thanks! |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Add semver to go.mod * Bring back tests for sourcegraphVersionCheck * Extract version check into public function * Move check for gzip compression to campaigns service * Fix unmarshaling of sourcegraph version * Add CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #336 and addresses this comment #336 (comment) and the broken build (see #336 (comment)) by
api.Client(vs. trying to encode every request)gzip: boolflag a property of theapi.Requeststruct to fix the data raceapi.Clientand moving it into thecampaigns.Servicewhere it's used to determine whether gzip compression should be used or notsourcegraphVersionCheckfunctioncampaigns.Serviceto query the version