Add visual step for resolving repositories#314
Merged
Conversation
Also fixes unsupported repositories aborting the workflow. We now simply skip those and let the user know.
bd6b8f3 to
e7d88d3
Compare
Contributor
|
I added a changelog entry and changed the code to use the helper functions we already had. The code looks good to me. If @LawnGnome and @chrispine don't have any objections, I'd merge it. |
mrnugget
approved these changes
Sep 14, 2020
LawnGnome
approved these changes
Sep 14, 2020
| repos, err := svc.ResolveRepositories(ctx, campaignSpec) | ||
| if err != nil { | ||
| if _, ok := err.(campaigns.UnsupportedRepoSet); ok { | ||
| campaignsCompletePending(pending, "Resolved repositories. Found unsupported codehosts.") |
Contributor
There was a problem hiding this comment.
Should we also display the list of unsupported repositories? This feels exceptional enough that users will want as much detail as possible, generally speaking.
Contributor
There was a problem hiding this comment.
Done! Happy to update the formatting of this in the future, but before I dive into the output lib right before branch cut, I think I'll go with the minimal but readable/copy-pastable version.
Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Add visual step for resolving repositories Also fixes unsupported repositories aborting the workflow. We now simply skip those and let the user know. * Use helper functions to print resolve-repos progress * Add changelog entry * Update CHANGELOG.md Co-authored-by: Adam Harvey <aharvey@sourcegraph.com> * Print which repositories are being skipped Co-authored-by: Thorsten Ball <mrnugget@gmail.com> Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes unsupported repositories aborting the workflow. We now simply skip those and let the user know.
Since this step can take some time, I was always confused what src-cli does. It resolves repositories apparently.
Closes #310