campaigns: allow partial publishing of changesets#294
Conversation
|
NICE! I like this the most so far. Two thoughts:
I feel like we're now 95% there! |
81e49c8 to
3c5a372
Compare
|
This is roughly updated in line with the RFC and its discussion. One thing we should talk about further is that I've separated out the schema and So, concerns? |
|
Few thoughts on the schema and
|
We don't, but we will, as you said. I'm happy enough to cut this back and embed the logic in
Exactly. |
66343c3 to
7d1f8a6
Compare
eseliger
left a comment
There was a problem hiding this comment.
Very cool, so simple and straightforward!
7d1f8a6 to
58286e6
Compare
|
Flipped to review-ready. I'm going to dismiss the existing approvals, but I don't think there's anything controversial here. The original branch that supported strings is pushed to the |
This is a prototype of the option being presented in RFC 228. It needs to be used in conjunction with sourcegraph/sourcegraph#13476.
Note that this PR adds a dependency on https://github.com/LawnGnome/campaign-schema for schema-related code shared between this PR and sourcegraph/sourcegraph#13476; my intention is to move this to https://github.com/sourcegraph/campaignutils if accepted.
An example of the type of campaign you could run with this is: