Skip to content

Escape arguments to curl#1

Merged
emidoots merged 1 commit into
masterfrom
shell-escape
Apr 24, 2018
Merged

Escape arguments to curl#1
emidoots merged 1 commit into
masterfrom
shell-escape

Conversation

@chrismwendt

@chrismwendt chrismwendt commented Apr 24, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Previously, whitespace in the GraphQL input could get compressed away.

curl commands now look like this:

curl \
   -H 'Authorization: token abcdef' \
   -d \{\"query\":\"query {  currentUser { username } }\",\"variables\":\{}} \
   sourcegraph.com/.api/graphql

@emidoots

emidoots commented Apr 24, 2018

Copy link
Copy Markdown
Member

Question about your solution here: prior to this change running this command:

echo 'query($query: String!) {                                                                                                                                   
  search(query: $query) {
    results {
      resultCount
    }
  }
}' | src api -vars '{"query": "abc"}' --get-curl 'query=abc=foo' 'foo=bar'

Would produce:

curl \
   -H 'Authorization: token <redacted>' \
   -d '{"query":"query($query: String!) { search(query: $query) { results { resultCount } } }","variables":{"foo":"bar","query":"abc=foo"}}' \
   https://sourcegraph.com/.api/graphql

Now it produces (very long line, see horizontal scrollbar):

curl \
   -H 'Authorization: token <redacted>' \
   -d '{"query":"query($query: String!) {                                                                                                                                   \n  search(query: $query) {\n    results {\n      resultCount\n    }\n  }\n}\n","variables":{"foo":"bar","query":"abc=foo"}}' \
   https://sourcegraph.com/.api/graphql

@chrismwendt

chrismwendt commented Apr 24, 2018

Copy link
Copy Markdown
Contributor Author

Yeah, unfortunately there is no golang implementation of GraphQL minification (there's a Node.js one https://github.com/rse/graphql-query-compress).

There appears to be a bunch of trailing whitespace on the first line of your query, in particular.

@emidoots

emidoots commented Apr 24, 2018

Copy link
Copy Markdown
Member

Yeah actually you are right, I had missed the case where someone might have a literal " whitespace " in their query which would get minified away by my naive implementation. This is much more correct

@emidoots emidoots merged commit accbe1f into master Apr 24, 2018
@emidoots emidoots deleted the shell-escape branch April 24, 2018 22:06
@mrnugget mrnugget mentioned this pull request Apr 26, 2021
Merged
@mrnugget mrnugget mentioned this pull request Dec 15, 2021
Merged
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@chrismwendt
Escape arguments to curl (#1)
68209cd
@DaedalusG DaedalusG mentioned this pull request Nov 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emidoots emidoots emidoots approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrismwendt @emidoots