This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(release): check for marker in container files instead of binary#64205
Merged
Conversation
Strum355
approved these changes
Aug 1, 2024
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
…64205) Frontend assets are not embedded into the binary anymore instead they're added to the final container image at `/assets-dist`. In this PR we check the directory inside the image for the marker instead of the binary Closes DINF-176 ## Test plan Tested locally ``` sg release run test --version 1.2.3 👉 [ setup] Finding release manifest in "." [ setup] No explicit branch name was provided, assuming current branch is the target: main [ setup] Found manifest for "sourcegraph" (github.com/sourcegraph/sourcegraph) [ meta] Owners: @sourcegraph/release [ meta] Repository: github.com/sourcegraph/sourcegraph 👉 [ vars] Variables [ vars] tag="1.2.3" [ vars] config="{\"version\":\"v1.2.3\",\"inputs\":\"\",\"type\":\"patch\"}" [ vars] git.branch="main" [ vars] is_development="false" [ vars] version="v1.2.3" 👉 [ reqs] Checking requirements... [ reqs] ✅ jq [ reqs] 🔕 Buidkite access token (excluded for test) [ reqs] 🔕 GitHub Token to submit changelogs (excluded for test) 👉 [ test] Running testing steps for v1.2.3 👉 [ step] Running step "check:frontend and server image contain bundle" [check:frontend and server image contain bundle] pulling frontend image us.gcr.io/sourcegraph-dev/frontend:insiders [check:frontend and server image contain bundle] insiders: Pulling from sourcegraph-dev/frontend [check:frontend and server image contain bundle] Digest: sha256:1256bfb7c64bee0f11a3d0b82af6899f1d3fe22c0d6f3875a877c5f8f8b0e963 [check:frontend and server image contain bundle] Status: Image is up to date for us.gcr.io/sourcegraph-dev/frontend:insiders [check:frontend and server image contain bundle] us.gcr.io/sourcegraph-dev/frontend:insiders [check:frontend and server image contain bundle] checking frontend has web-bundle at /assets-dist inside the container [check:frontend and server image contain bundle] WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested [check:frontend and server image contain bundle] pulling server image us.gcr.io/sourcegraph-dev/server:insiders [check:frontend and server image contain bundle] insiders: Pulling from sourcegraph-dev/server [check:frontend and server image contain bundle] Digest: sha256:592c4e94ced4990a3b461eb474d5e7fee9c408d93ba4df44220b22f7d39ea645 [check:frontend and server image contain bundle] Status: Image is up to date for us.gcr.io/sourcegraph-dev/server:insiders [check:frontend and server image contain bundle] us.gcr.io/sourcegraph-dev/server:insiders [check:frontend and server image contain bundle] checking server has web-bundle at /assets-dist inside the container [check:frontend and server image contain bundle] WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested [ step] Step "check:frontend and server image contain bundle" succeeded ``` <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> ## Changelog * release: check contiainer directory `/assets-dist` for marker instead of frontend binary <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> (cherry picked from commit 78064ba)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend assets are not embedded into the binary anymore instead they're added to the final container image at
/assets-dist.In this PR we check the directory inside the image for the marker instead of the binary
Closes DINF-176
Test plan
Tested locally
Changelog
/assets-distfor marker instead of frontend binary