Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(ci): post instructions for PR sections in a comment#64176

Merged
jhchabran merged 2 commits into
mainfrom
jh/pr-instructions-in-comments
Jul 31, 2024
Merged

chore(ci): post instructions for PR sections in a comment#64176
jhchabran merged 2 commits into
mainfrom
jh/pr-instructions-in-comments

Conversation

@jhchabran

@jhchabran jhchabran commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Follow-up to https://github.com/sourcegraph/devx-support/issues/1130

Moving the doc links to a comment is merely a few lines of GitHub Script, so it's worth doing it for better merge commit messages.

Test plan

This PR itself was the test, as you can see below the comments that resulted from this new GH workflow. Btw, the second one is the one you'll see in the code here. I went for a oneliner to avoid cluttering the UI.

@cla-bot cla-bot Bot added the cla-signed label Jul 31, 2024
@github-actions

Copy link
Copy Markdown
Contributor

💡 Learn more about each section:
- PR description tips
- Test Plan
- Changelog

@jhchabran jhchabran force-pushed the jh/pr-instructions-in-comments branch 2 times, most recently from 85661fd to 1ba2ba9 Compare July 31, 2024 09:28
@jhchabran jhchabran closed this Jul 31, 2024
@jhchabran jhchabran reopened this Jul 31, 2024
@github-actions

Copy link
Copy Markdown
Contributor

💡 Learn more about each section: PR description tips, Test Plan and Changelog.

@jhchabran jhchabran force-pushed the jh/pr-instructions-in-comments branch from 1ba2ba9 to 9ca12fe Compare July 31, 2024 09:31
@jhchabran jhchabran requested review from a team and varungandhi-src July 31, 2024 09:32
@jhchabran jhchabran added the no-changelog Exclude this PR from the next changelog. label Jul 31, 2024
@jhchabran jhchabran enabled auto-merge (squash) July 31, 2024 09:36

@varungandhi-src varungandhi-src left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jhchabran jhchabran merged commit 7621038 into main Jul 31, 2024
@jhchabran jhchabran deleted the jh/pr-instructions-in-comments branch July 31, 2024 09:37
jhchabran added a commit that referenced this pull request Jul 31, 2024
jhchabran referenced this pull request Jul 31, 2024
…64187)

Reverts sourcegraph/sourcegraph#64176

Test-plan: CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed no-changelog Exclude this PR from the next changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants