This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(appliance): version selector defaults when relreg down#64173
Merged
craigfurman merged 1 commit intoJul 31, 2024
Merged
Conversation
Basic fallback. See comments for a potential replacement. Even so, this gets us moving on day 0.
b973e54 to
639a90c
Compare
DaedalusG
approved these changes
Jul 31, 2024
craigfurman
pushed a commit
that referenced
this pull request
Jul 31, 2024
Basic fallback. See comments for a potential replacement. Even so, this gets us moving on day 0. Closes https://linear.app/sourcegraph/issue/REL-313/handle-for-releaseregistry-down-in-install-page.
DaedalusG
reviewed
Jul 31, 2024
| // filesystem. In Kubernetes, this could be derived from a | ||
| // ConfigMap, with the files being distributed to airgap users | ||
| // out-of-band. | ||
| const publicVersions = ['v5.5.2463'] |
Contributor
There was a problem hiding this comment.
We could also maybe embed a var at build time similar to how migrator tends to handle this. Might be saying hte same thing as you though.
Contributor
Author
There was a problem hiding this comment.
That's a good idea, and isn't similar to what I was saying 😁
My comment was more speculating on how we might handle airgapped customers, since this fallback path will always be needed for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic fallback. See comments for a potential replacement. Even so, this gets us moving on day 0.
Closes https://linear.app/sourcegraph/issue/REL-313/handle-for-releaseregistry-down-in-install-page.
Test plan
Manual tire-kicking with
pnpm run dev, and hacking the hardcoded relreg URL to be invalid.Changelog