This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Bubble precise Usages instead of Locations#64118
Merged
Conversation
varungandhi-src
commented
Jul 29, 2024
varungandhi-src
commented
Jul 29, 2024
varungandhi-src
commented
Jul 29, 2024
varungandhi-src
commented
Jul 29, 2024
kritzcreek
suggested changes
Jul 29, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
Just some things I spotted, will work through the rest in a bit
varungandhi-src
added a commit
that referenced
this pull request
Jul 31, 2024
This patch wires up the newly changed APIs in #64118 to the GraphQL API, enabling precise support in the usagesForSymbol API. It also handles pagination. Fixes https://linear.app/sourcegraph/issue/GRAPH-573 ## Test plan Manually tested. Will add automated tests in follow-up PR. ## Changelog - Adds support for precise code navigation to the experimental `usagesForSymbol` API, which can be used to implement a reference panel or similar functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the code so that the core APIs we need
for precise usagesForSymbol actually return (Upload)Usages instead
of just (Upload)Locations, so that we have the usage kind information
as well as the symbol names available. I will be handling the GraphQL layer
for converting the Usages to appropriate Resolvers in a follow-up PR.
Test plan
Modified a bunch of existing mock tests. 🤷🏽