This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Adding HTTP Requests support for Azure OpenAI#64116
Merged
Merged
Conversation
emidoots
reviewed
Jul 28, 2024
ffad1c4 to
adafbfe
Compare
arafatkatze
commented
Jul 29, 2024
emidoots
reviewed
Jul 29, 2024
emidoots
approved these changes
Jul 29, 2024
emidoots
left a comment
Member
There was a problem hiding this comment.
Looks like the right solution to me. Make sure to get security sign-off.
evict
reviewed
Jul 30, 2024
Co-authored-by: Vincent <evict@users.noreply.github.com>
Co-authored-by: Vincent <evict@users.noreply.github.com>
Co-authored-by: Vincent <evict@users.noreply.github.com>
Co-authored-by: Vincent <evict@users.noreply.github.com>
evict
approved these changes
Jul 30, 2024
arafatkatze
added a commit
that referenced
this pull request
Jul 30, 2024
This PR adds special support for http requests to azure OpenAI and changes special customer configs to use HTTP instead of HTTPS. Tested this PR locally <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> --------- Co-authored-by: Vincent <evict@users.noreply.github.com>
nelsonjr
referenced
this pull request
Jul 31, 2024
This is a backport PR to add changes from https://github.com/sourcegraph/sourcegraph/pull/64116 to v5.5.x to main to create a release of the frontend. ## Test plan <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> --------- Co-authored-by: Vincent <evict@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds special support for http requests to azure OpenAI and changes special customer configs to use HTTP instead of HTTPS.
Test plan
Tested this PR locally
Changelog