Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gerrit: Add support for repositoryPathPattern#64102

Merged
eseliger merged 1 commit into
mainfrom
es/07-26-gerritaddsupportforrepositorypathpattern
Jul 26, 2024
Merged

gerrit: Add support for repositoryPathPattern#64102
eseliger merged 1 commit into
mainfrom
es/07-26-gerritaddsupportforrepositorypathpattern

Conversation

@eseliger

@eseliger eseliger commented Jul 26, 2024

Copy link
Copy Markdown
Member

Most other code host connections we support have this property to control the generated name, but for some reason it was forgotten for Gerrit.

This PR adds it, plus a few tests.

Screenshot 2024-07-26 at 14.04.35@2x.png

Test plan: Added tests, cloned a gerrit repo locally.

Changelog

Added support for the repositoryPathPattern setting for Gerrit code host connections.

Most other code host connections we support have this property to control the generated name, but for some reason it was forgotten for Gerrit.

This adds it, plus a few tests.

Test plan: Added tests, cloned a gerrit repo locally.
@cla-bot cla-bot Bot added the cla-signed label Jul 26, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jul 26, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

@eseliger eseliger marked this pull request as ready for review July 26, 2024 12:06
@eseliger eseliger requested a review from a team July 26, 2024 12:07
@eseliger eseliger merged commit d249b8f into main Jul 26, 2024

Copy link
Copy Markdown
Member Author

Merge activity

@eseliger eseliger deleted the es/07-26-gerritaddsupportforrepositorypathpattern branch July 26, 2024 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants