This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix: Fix Chrome stack overflow during highlighting#64072
Merged
Conversation
eseliger
approved these changes
Jul 25, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
Wonder what a flamegraph of this looks like, and if some sort of chunking (like push 1k at a time) could help in case it's bad - but approving for the fix.
Contributor
Author
This operation should only be happening once per blob, so I don't think it's worth micro-optimizing the pushes; the lookups are much more expensive. |
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Using the spread operator with large arrays can trigger a stack overflow in Chrome/V8. For example, see: - nodejs/node#16870 In a highlighting context, we can have 10k-100k occurrences in a file, so let's avoid using the spread operator. Fixes https://linear.app/sourcegraph/issue/GRAPH-772 ## Test plan Manually tested against sample file.  ## Changelog - Fixes a Chrome-specific stack overflow when highlighting large files. (cherry picked from commit 2644e24)
varungandhi-src
added a commit
that referenced
this pull request
Jul 25, 2024
…64074) Using the spread operator with large arrays can trigger a stack overflow in Chrome/V8. In a highlighting context, we can have 10k-100k occurrences in a file, so let's avoid using the spread operator. Fixes https://linear.app/sourcegraph/issue/GRAPH-772 ## Test plan Manually tested against sample file.  ## Changelog - Fixes a Chrome-specific stack overflow when highlighting large files. <br> Backport 2644e24 from #64072 Co-authored-by: Varun Gandhi <varun.gandhi@sourcegraph.com>
Member
|
Good find -- thank you for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the spread operator with large arrays can trigger a
stack overflow in Chrome/V8. For example, see:
In a highlighting context, we can have 10k-100k occurrences
in a file, so let's avoid using the spread operator.
Fixes https://linear.app/sourcegraph/issue/GRAPH-772
Test plan
Manually tested against sample file.
Changelog