This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(source): Fix issue where worker would crash if a Bitbucket Cloud token couldn''t be refreshed#64028
Merged
Merged
Conversation
eseliger
approved these changes
Jul 24, 2024
pjlast
added a commit
that referenced
this pull request
Jul 24, 2024
… Bitbucket Cloud token couldn''t be refreshed (#64037) A Bitbucket Cloud incident caused APIs to error which caused Bitbucket Cloud OAuth tokens to fail to refresh. This revealed that the Bitbucket Cloud client called `oauthutil.DoRequest` with a `nil` logger, causing a nil pointer dereference. This PR simply creates the logger before calling `DoRequest`, which is what the other clients do. ## Test plan No more cases of DoRequest with a nil logger. ## Changelog - Fixed an issue where a Bitbucket Cloud OAuth token failing to refresh would crash the `worker` service. <br> Backport bc036ad from #64028 Co-authored-by: Petri-Johan Last <petri.last@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Bitbucket Cloud incident caused APIs to error which caused Bitbucket Cloud OAuth tokens to fail to refresh. This revealed that the Bitbucket Cloud client called
oauthutil.DoRequestwith anillogger, causing a nil pointer dereference.This PR simply creates the logger before calling
DoRequest, which is what the other clients do.Test plan
No more cases of DoRequest with a nil logger.
Changelog
workerservice.